Have DiscoverableAsTestContent enumeration produce some Sequence instead of AnySequence.
#1122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of `AnySequence`. This PR changes how `DiscoverableAsTestContent` enumeration works so that we can return `some Sequence` instead of `AnySequence`. We do so by removing the `~Copyable` constraint on the protocol, which subsequently causes the compiler to get confused and crash trying to represent `some Sequence<TestContentRecord<T>>` where `T: DiscoverableAsTestContent`.
grynspan
added
enhancement
grynspan
changed the title
DiscoverableAsTestContent enumeration produce some Sequence …DiscoverableAsTestContent enumeration produce some Sequence instead of AnySequence.
|
@swift-ci test |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how
DiscoverableAsTestContentenumeration works so that we can returnsome Sequenceinstead ofAnySequence. We do so by removing the~Copyableconstraint on the protocol, which subsequently causes the compiler to get confused and crash trying to representsome Sequence<TestContentRecord<T>>whereT: DiscoverableAsTestContent.The only supported/allowed consumers of the
DiscoverableAsTestContentprotocol are Swift Testing and the experimental Playgrounds package, neither of which uses (or needs to use) a move-only type here. Earlier,ExitTestconformed toDiscoverableAsTestContent, but this was changed and is no longer necessary.Checklist: