Migrate bin/*.js to TypeScript, use tsx
#2866
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
commented
Jun 25, 2025
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "private": true, | |||
| "packageManager": "yarn@4.5.0", | |||
| "type": "module", | |||
There was a problem hiding this comment.
It should not impact src/**/assets packages
Kocal
force-pushed
the
migrate-bin-files-from-js-to-ts
branch
from
d2ac9ff to
640ebe5
Compare
Kocal
force-pushed
the
migrate-bin-files-from-js-to-ts
branch
from
640ebe5 to
de41146
Compare
|
Trusting you here :) |
|
I noticed using I may try to give to another change to |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types ✨
Following #2865, in fact I didn't go with Node &
--experimental-strip-typesflag, but with https://tsx.is/ instead.