Skip to content

docs(fix): install hast types in development only #25

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from

Conversation

felixranesberger
Copy link

Hi, I just read your documentation and think that installing the @types for hast should probably only be done for development only.

Signed-off-by: Felix Ranesberger <52704891+felixranesberger@users.noreply.github.com>
@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Mar 27, 2025

This comment has been minimized.

Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends on the use case.
As a library dependency is the only correct way, it needs to go downstream.
As an application it could go either way.

@remcohaszing
Copy link
Member

There are use cases where types (or anything really) may be a dev dependency. Whatever it is, depends on the project. For most use cases this is false. IMO we leave the instructions as-is.

@wooorm
Copy link
Member

wooorm commented Mar 27, 2025

It depends! There are also cases where other flags are useful. This section isn’t always 100% right for everyone and that’s fine. For me, it signals that it’s on the npm registry, and what the exact (scoped) package name is!

Thanks for thinking of this!

@wooorm wooorm closed this Mar 27, 2025

This comment has been minimized.

@wooorm wooorm added the 🙅 no/wontfix This is not (enough of) an issue for this project label Mar 27, 2025
@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 👋 phase/new Post is being triaged automatically labels Mar 27, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🙅 no/wontfix This is not (enough of) an issue for this project 👎 phase/no Post cannot or will not be acted on
Development

Successfully merging this pull request may close these issues.

4 participants