Skip to content

Ship desktop icon with systemd-ui #10

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AsciiWolf
Copy link
Contributor

The applications-system icon currently used by the desktop file is from an adwaita-icon-theme(-legacy). This creates an unnecessary dependency.

This PR bundles the applications-system.svg icon from legacy GNOME/Adwaita icon theme (archived here).

Fixes #9.

@AsciiWolf
Copy link
Contributor Author

@mathstuf Sorry for the mess, I somehow managed to break my Git tree. Everything should be correct now. Please review, thanks!

@AsciiWolf AsciiWolf closed this Jun 17, 2025
@AsciiWolf AsciiWolf reopened this Jun 17, 2025
@AsciiWolf
Copy link
Contributor Author

AsciiWolf commented Jun 19, 2025

@mathstuf I have fully tested this and the previous PR on my Debian Testing system:

# Install missing packages on my Debian Testing system
$ sudo apt install valac libgee-0.8-dev libnotify-dev

# Create the build dir and build systemd-ui
$ mkdir build
$ cd build
$ meson ..
...
$ ninja
...

# Install systemd-ui
$ sudo ninja install
[0/1] Installing files
Installing src/systemadm to /usr/bin
Installing src/systemd-gnome-ask-password-agent to /usr/bin
Installing man/systemadm.1 to /usr/share/man/man1
Installing /home/asciiwolf/systemd-ui/src/io.systemd.systemadm.desktop to /usr/share/applications
Installing /home/asciiwolf/systemd-ui/src/io.systemd.systemadm.svg to /usr/share/icons/hicolor/scalable/apps
Installing /home/asciiwolf/systemd-ui/src/io.systemd.systemadm.metainfo.xml to /usr/share/metainfo
Installing /home/asciiwolf/systemd-ui/src/systemd-gnome-ask-password-agent.rules to /usr/share/polkit-1/rules.d
Installing /home/asciiwolf/systemd-ui/src/systemd-gnome-ask-password-agent.path to /usr/lib/systemd/user
Installing /home/asciiwolf/systemd-ui/src/systemd-gnome-ask-password-agent.service to /usr/lib/systemd/user
Installing /home/asciiwolf/systemd-ui/LICENSE to /usr/share/doc/systemd-ui
Installing /home/asciiwolf/systemd-ui/CODING_STYLE to /usr/share/doc/systemd-ui
$ cat /usr/share/applications/io.systemd.systemadm.desktop
[Desktop Entry]
Name=systemadm
Comment=Manage systemd units
Exec=systemadm
Icon=io.systemd.systemadm
Terminal=false
Type=Application
Categories=System;Settings;

$ file /usr/share/icons/hicolor/scalable/apps/io.systemd.systemadm.svg
/usr/share/icons/hicolor/scalable/apps/io.systemd.systemadm.svg: SVG Scalable Vector Graphics image, ASCII text, with very long lines (3607)

$ cat /usr/share/metainfo/io.systemd.systemadm.metainfo.xml
<?xml version="1.0" encoding="UTF-8"?>
<!-- Copyright 2014 Zbigniew J\u0119drzejewski-Szmek <zbyszek@in.waw.pl> -->
<component type="desktop-application">
  <id>io.systemd.systemadm</id>
  <metadata_license>CC0-1.0</metadata_license>
  <project_license>GPL-2.0-or-later</project_license>
  <name>systemadm</name>
...

Everything appears to be correct.

@AsciiWolf
Copy link
Contributor Author

Here are some screenshots:

Desktop entry in GNOME:

desktop-entry

App metadata (from the metainfo file) in GNOME Software:

software-metainfo

Both correct.

systemd-ui

The app window itself still has no icon, but that is a different problem not related to this (or the previous) PR.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a different desktop icon
1 participant