Skip to content

Remove redundant URI path segment check in parse_request #192

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eugenepaniot
Copy link
Contributor

This commit proposes the removal of a redundant URI path segment check within the parse_request function.

Currently, the code contains a loop that iterates over each path segment in the parsed URI, checking for the presence of . or .. segments. However, this check is unnecessary since HTTP requests with /./ or /../ in the URI are automatically corrected by the http server, converting them into // which is the expected behavior.

The primary reason for removing this check is to address an issue detailed in the GitHub pull request #173. In cases where Tarantool decodes a request like .%2F.html.%2F to ./.html./, the current code implementation throws an invalid uri error. However, this behavior is not desired. Instead, it is expected to return the URI as is.

@0x501D
Copy link
Member

0x501D commented Dec 8, 2023

Please rebase with master branch.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants