Use a separate thread to watch for dead processes #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure. Let me check it. |
|
Guess it doesn't work. I just created a redis broker and tried to modify a file several times. I don't know why is it happening, because everything seems to be ok in the code. But here's the screencast: out.mp4 |
s3rius
requested changes
Mar 28, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help with #63
"Works on my machine" (c), but I have a somewhat unusual setup and I don't have enough knowledge of the project to properly test this (I've run a bunch of manual tests, but I'm still not convinced that this works in all configurations).
@s3rius can you look into this and test on your setup as well? We tried a similar approach together and I remember that it didn't work for some reason.