Skip to content

Use a separate thread to watch for dead processes #81

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kolaer
Copy link
Contributor

@Kolaer Kolaer commented Mar 28, 2023

Should help with #63

"Works on my machine" (c), but I have a somewhat unusual setup and I don't have enough knowledge of the project to properly test this (I've run a bunch of manual tests, but I'm still not convinced that this works in all configurations).

@s3rius can you look into this and test on your setup as well? We tried a similar approach together and I remember that it didn't work for some reason.

@s3rius
Copy link
Member

s3rius commented Mar 28, 2023

Sure. Let me check it.

@Kolaer Kolaer requested a review from s3rius March 28, 2023 18:10
@s3rius
Copy link
Member

s3rius commented Mar 28, 2023

Guess it doesn't work. I just created a redis broker and tried to modify a file several times. I don't know why is it happening, because everything seems to be ok in the code. But here's the screencast:

out.mp4

Copy link
Member

@s3rius s3rius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. But it doesn't work.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants