Skip to content

change links checked output from !quiet to verbose #438

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jsoref
Copy link

@jsoref jsoref commented Apr 8, 2025

This doesn't technically remove the line. It just changes the guard from !quiet to verbose. I'm also willing to remove it entirely, but as there is a verbose flag, it seemed somewhat worthwhile to honor that instead of just removing the output entirely.

@BaseMax
Copy link
Collaborator

BaseMax commented Apr 8, 2025

Hi greetings from Belgium, Need to check more deeply. I am on trip now - in Belgium.

Need to check to make sure logic is right.

What is opts.verbose value? what about opts.quiet?

@jsoref
Copy link
Author

jsoref commented Apr 8, 2025

They both appear to be bool-ish values:

if (opts.verbose) {
if (result.err) {
console.log(
" [%s] %s → Status: %s %s",
statusLabels[result.status],
result.link,
result.statusCode,
result.err
);
} else {
console.log(" [%s] %s → Status: %s", statusLabels[result.status], result.link, result.statusCode);
}
} else if (!opts.quiet) {
console.log(" [%s] %s", statusLabels[result.status], result.link);
}

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the per file link check total
2 participants