Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: update subscriptions in device #1475

Merged
merged 6 commits into from
Feb 5, 2024
Merged

fix: update subscriptions in device #1475

merged 6 commits into from
Feb 5, 2024

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Oct 2, 2023 •
edited
Loading

Needed by test/unit/ngsiv2/ngsiService/subscriptions-test.js using MongoDB instead of Memory #1472

Maybe related #1086 ?

@AlvaroVega AlvaroVega marked this pull request as ready for review October 2, 2023 09:20
@fgalan
Copy link
Member

fgalan commented Oct 11, 2023

Not for version 3.5.0

@AlvaroVega AlvaroVega requested a review from fgalan February 5, 2024 08:41
@AlvaroVega
Copy link
Member Author

AlvaroVega commented Feb 5, 2024 •
edited
Loading

subscriptions are controlled by a subscription service:
https://github.com/telefonicaid/iotagent-node-lib/blob/master/lib/services/ngsi/subscriptionService.js

https://github.com/telefonicaid/iotagent-node-lib/blob/master/test/unit/ngsiv2/ngsiService/subscriptions-test.js

fgalan
fgalan reviewed Feb 5, 2024
View reviewed changes
fgalan
fgalan reviewed Feb 5, 2024
View reviewed changes
fgalan
fgalan approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit 301280a into master Feb 5, 2024
@fgalan fgalan deleted the fix/update_subscriptions_device branch February 5, 2024 15:46
@fgalan fgalan mentioned this pull request Feb 5, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fgalan fgalan fgalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlvaroVega @fgalan