Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added Power support #2129

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

PankhudiJ17
Copy link

@PankhudiJ17 PankhudiJ17 commented Feb 18, 2025

Hello Team,
we have raised this PR to add power support. We have built tf-io using the following steps:

export BAZEL_OPTIMIZATION="--copt=-mcpu=power9 --copt=-mvsx --copt=-maltivec"
bazel build -s --verbose_failures $BAZEL_OPTIMIZATION --copt="-Wno-error=array-parameter=" --copt="-I/usr/include/tirpc" //tensorflow_io/... //tensorflow_io_gcs_filesystem/... --cpu=ppc

We have also updated the version of rules_python from 0.23.1 to 0.31.0 as it has a bug fix for ppc64le as mentioned in the issue below:
Issue Link

Please let us know, your thoughts about this.
Thank you!

Copy link

google-cla bot commented Feb 18, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Signed-off-by: Pankhudi Jain <Pankhudi.Jain@ibm.com>
@PankhudiJ17 PankhudiJ17 marked this pull request as draft February 18, 2025 12:34
@PankhudiJ17 PankhudiJ17 marked this pull request as ready for review February 20, 2025 12:40
@alhad-deshpande
Copy link

@mihaimaruseac @yongtang

Can you please review this PR?

Copy link

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But see #2120 (comment)

@alhad-deshpande
Copy link

Thanks @mihaimaruseac for approving this PR.

What will be next steps to get it merged?

@mihaimaruseac
Copy link

My review is not binding. See #2120 comment

@alhad-deshpande
Copy link

@yongtang
Can you please review the PR?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants