[pull] master from robotframework:master #145
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Manage this branch in SquashTest this branch here: https://master-n02a3.squash.io |
Try to get deprecations done in RF 7.3 and removals in RF 8.0.
To some extend related to documenting variable type conversion (#3278).
Earlier syntax was `${name:pattern: type}`, but now it is
`${name: type:pattern}`. This is more consistent with the general
variable type syntax `${name: type}`. Part of #3278.
Error messages enhanced in these cases: - Embedded argument value is invalid. - Argument default value is invalid.
- Explicit test for embedded args regexp with leading/trailig spaces. - Add one test for type conversion also to embedded arguments suite.
- Remove Python 2 reference - Add section about type hints
Also some refactoring: - Parse arguments to VariableMatch objects just once. - Reorder methods. Fixes #5443.
Hopefully this doesn't make tests flakey...
…yword This only affects a situation where - a name of an executed keyword contains a variable and - the name matches a different keyword depending on are variables replaced or not. After this change an exact match after variables have been resolved has a precedence regardless what the original name would match. Fixes #5444.
- Remind to run `invoke format`. - Enhance Libdoc template generation instructions. - Update the outdated list where to send announcements.
Most importantly, document automatic code formatting. Fixes #5441.
Iterate the file object directly instead. Fixes #5447.
Using `skip` is a bit safer, because forgetting to use `on` would disable formatting for the remaining file. We also mostly use `skip` elsewhere.
Use the formatting style enforced by autoformatters even when formatting is disabled for other reasons.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )