Skip to content

Project update #10

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Project update #10

wants to merge 4 commits into from

Conversation

jonra1993
Copy link

@jonra1993 jonra1993 commented Mar 12, 2022

Thanks for this fast API setup. In this Pull request, I have added some suggestions on issues

  1. nullable=False on id to avoid problems on migrations
  2. settings file
  3. db file upgrade
  4. readme add how to make migrations with alembic

@mjhea0
Copy link
Contributor

mjhea0 commented Mar 13, 2022

Thanks. Since the project is tied to a tutorial -- https://testdriven.io/blog/fastapi-sqlmodel/ -- the code and tutorial need to be updated at the same time. I should have some time later this month to look at this.

@amirtds amirtds mentioned this pull request Jul 10, 2023
@mjhea0
Copy link
Contributor

mjhea0 commented Jul 10, 2023

Apologies for the delay, @jonra1993. It's really difficult to accept PRs from folks who are not also updating the tutorial at the same time. @amirtds and I updated both. We captured most of your changes. If you still want to contribute, please address the merge conflicts. Thank you!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants