-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Adding Dockerfile #1
base: master
Are you sure you want to change the base?
Conversation
I disagree with moving things to a separate subdirectory; this git repository is supposed to be just the bundle, not the entire NodeCG setup. (See https://github.com/thebiggame/streamnet_config/tree/master/nodecg) It's worth noting that other bundles do it this way as well: https://github.com/GamesDoneQuick/agdq18-layouts - this also allows for usage of the |
Good point didn't think about that aspect. Maybe i'll also put the Dockerfile in a separate repo..thoughts? Do you see any obvious issue with the version bump? |
Step ahead of you: see https://github.com/thebiggame/streamnet_config/blob/master/nodecg/Dockerfile (though maybe breaking it out of there is sensible?????)
Not that I can see from looking at the release notes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Directory changes should be removed. Dockerfile should be refactored (and is arguably overkill, see conversation)
Version bump is fine.
I have added the tBG bundle to a Dockerfile based on nodecg/nodecg.
Since this base image takes the latest nodecg release (currently 1.2.2) i have bumped the required version in
package.json
. It still seems to work..