Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Had to adjust a few bits to get the various containers to build #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Had to adjust a few bits to get the various containers to build #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions README.md
View file
Original file line number Diff line number Diff line change
@@ -3,3 +3,11 @@
`streamnet_config` contains the configuration bundle / dockerfiles that build up the Streamnet server (aka stream.biggame).

A docker-compose manifest is included in the root which should spin everything up (but you'll need to copy in a nodecg bundle to `/nodecg/bundles`, as well as the `streamnet_app` application to `/app`).

## To Install

```console
git clone --recurse-submodules git@github.com:thebiggame/streamnet_config.git
cd streamnet_config
docker-compose up
```
2 changes: 2 additions & 0 deletions nodecg/Dockerfile
View file
Original file line number Diff line number Diff line change
@@ -3,6 +3,8 @@ FROM nodecg/nodecg:latest
# Copy Bundle
COPY bundles /usr/src/app/bundles

# A hack to get the bower install to work. Something to do with .git files confusing it all. Meh.. https://github.com/bower/bower/issues/1492
RUN cd /usr/src/app/bundles/thebiggame && rm .git .gitignore .gitattributes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally think this should be handled with a .dockerignore file, for two reasons: first, it means these files don't end up in the image at all, saving layer size; and second, it doesn't require an extra RUN layer.

Documentation on .dockerignore here: https://docs.docker.com/engine/reference/builder/#dockerignore-file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah good idea, i'll get on it

# Install dependencies
RUN cd /usr/src/app/bundles/thebiggame && npm install --production
RUN cd /usr/src/app/bundles/thebiggame && bower install --allow-root