Skip to content

Fix "FROM" with the specified database #80

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 10 commits into
base: 1.5
Choose a base branch
from

Conversation

rodion-k
Copy link

@rodion-k rodion-k commented Aug 8, 2021

No description provided.

Copy link
Collaborator

@homersimpsons homersimpsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🎉 Looks overall good.

Just 2 small comments. Also about PHPStan's output mabe you can find a way to restrict the types.

@@ -51,12 +51,12 @@ public function current()
/**
* @return int
*/
public function key()
public function key(): mixed
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure that we should introduce the mixed return type as this would require to target newer PHP version. What's your opinin on this ?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants