-
Notifications
You must be signed in to change notification settings - Fork 15
Fix "FROM" with the specified database #80
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: 1.5
Are you sure you want to change the base?
Conversation
…rapolation is off
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🎉 Looks overall good.
Just 2 small comments. Also about PHPStan's output mabe you can find a way to restrict the types.
@@ -51,12 +51,12 @@ public function current() | |||
/** | |||
* @return int | |||
*/ | |||
public function key() | |||
public function key(): mixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure that we should introduce the mixed
return type as this would require to target newer PHP version. What's your opinin on this ?
No description provided.