Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Take into account global error handlers #332

Open
j3j5 opened this issue Mar 15, 2022 · 1 comment · May be fixed by #334
Open

Take into account global error handlers #332

j3j5 opened this issue Mar 15, 2022 · 1 comment · May be fixed by #334
Labels
enhancement New feature or request

Comments

@j3j5
Copy link
Contributor

j3j5 commented Mar 15, 2022

Hi there,

I was reading this thread on Twitter by Christian Lück and I immediately thought on Safe.

I just checked and just like on his example, this library uses error_get_last() without accounting for any other global error handlers set by the application. I checked fopen() but I guess the implementation is the same for all functions using error_get_last().

What do you think? Shall this be addressed? Would you like a MR?
@dbrekelmans
Copy link
Collaborator

Yeah, makes sense to me! Looking forward to the PR :)

Keep in mind that this change should be done in the generator, not in the individual generated files.

@j3j5 j3j5 linked a pull request Mar 18, 2022 that will close this issue
Draft
@clue clue mentioned this issue Apr 18, 2022
Merged
@dbrekelmans dbrekelmans added the enhancement New feature or request label Aug 4, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace error_get_last() with a custom error handler j3j5/safe
2 participants
@j3j5 @dbrekelmans