-
-
Notifications
You must be signed in to change notification settings - Fork 163
Replace error_get_last()
with a custom error handler
#334
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
Conversation
I am sorry, I didn't have the time to review your PR, i will check it this week. I also pinged @moufmouf who is much more expert in error_handlers |
4e98a78
to
847f5b6
Compare
I've rebased the branch and fixed the test. I'm updating the original description to mention the new PCRE Exception. |
…custom error handler
…_ and curl_share_)
847f5b6
to
6c2ad07
Compare
Reviving this project after a couple of years of inactivity, this PR looks like it might still be useful so I'm going to leave it open, but marking it as a draft until it is rebased on current master |
Given how long it has passed since I open this PR, I probably should just remake it instead of a simple rebase, I don't know why it's so big. I'll try to give it a try as soon as I have some free time. |
Feel free to recreate it if a rebase is too complex due to the project progress |
Try to fix #332
This is my first serious attempt at a PR on here, so please, any suggestion is welcome.
While doing this I realized the implementation for the exception handling on the curl module was wrong. With PHP8 the
$ch
parameter doesn't exist anymore and it's now$handle
. I fixed that and added the case for the other two new handles$multi_handle
and$share_handle
.I've also started using the new function (PHP 8.0+)
preg_last_error_msg()
to determine the error message onPcreException
.PHPStan throws no errors on my machine but I didn't have time to test it properly, so more eyes are welcome before merging.