Replace error_get_last() with a custom error handler
#334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am sorry, I didn't have the time to review your PR, i will check it this week. I also pinged @moufmouf who is much more expert in error_handlers |
j3j5
force-pushed
the
global_error_handler
branch
from
4e98a78 to
847f5b6
Compare
|
I've rebased the branch and fixed the test. I'm updating the original description to mention the new PCRE Exception. |
…custom error handler
…_ and curl_share_)
j3j5
force-pushed
the
global_error_handler
branch
from
847f5b6 to
6c2ad07
Compare
|
Reviving this project after a couple of years of inactivity, this PR looks like it might still be useful so I'm going to leave it open, but marking it as a draft until it is rebased on current master |
|
Given how long it has passed since I open this PR, I probably should just remake it instead of a simple rebase, I don't know why it's so big. I'll try to give it a try as soon as I have some free time. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix #332
This is my first serious attempt at a PR on here, so please, any suggestion is welcome.
While doing this I realized the implementation for the exception handling on the curl module was wrong. With PHP8 the
$chparameter doesn't exist anymore and it's now$handle. I fixed that and added the case for the other two new handles$multi_handleand$share_handle.I've also started using the new function (PHP 8.0+)
preg_last_error_msg()to determine the error message onPcreException.PHPStan throws no errors on my machine but I didn't have time to test it properly, so more eyes are welcome before merging.