Skip to content

fix: add direction tracking to carousel component #1574

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maj0rika
Copy link

@maj0rika maj0rika commented Apr 16, 2025

Closes #1551

📑 Description

Fixes an issue with carousel animations where the transition looked the same whether moving forward or backward.
This update introduces a forward state to track navigation direction — true when moving to the next slide, false for the previous one.
Now the carousel correctly animates in the appropriate direction based on user interaction.

Status

  • Not Completed
  • Completed

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

ℹ Additional Information

This PR fixes the issue reported in #1551 where the carousel animation was the same when moving backward as when moving forward. By tracking the direction with a forward state property (set to true for next slide and false for previous slide), we enable the carousel to use appropriate transition animations for each direction.

Commit message: fix: add direction tracking to carousel transitions

Summary by CodeRabbit

  • Improvement
    • Added slide direction tracking to enable proper animation when moving forward vs backward in the carousel.

Copy link

vercel bot commented Apr 16, 2025

@maj0rika is attempting to deploy a commit to the Themesberg Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Apr 16, 2025

Walkthrough

The changes update the Carousel component to explicitly track the direction of slide transitions. In the nextSlide and prevSlide functions, the _state.forward property is set to true or false respectively, reflecting the direction of navigation. This adjustment allows the carousel logic to distinguish between forward and backward transitions, likely enabling direction-specific animations. Additionally, a minor syntax correction was made to an import statement.

Changes

File(s) Change Summary
src/lib/carousel/Carousel.svelte Added explicit setting of _state.forward in nextSlide and prevSlide; fixed import syntax.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CarouselComponent

    User->>CarouselComponent: Clicks "Next"
    CarouselComponent->>CarouselComponent: Update slide index
    CarouselComponent->>CarouselComponent: Set _state.forward = true

    User->>CarouselComponent: Clicks "Previous"
    CarouselComponent->>CarouselComponent: Update slide index
    CarouselComponent->>CarouselComponent: Set _state.forward = false
Loading

Assessment against linked issues

Objective Addressed Explanation
Differentiate forward and backward transitions in carousel (#1551)

Poem

The carousel spins, now forward, now back,
With code that keeps track of the slide's new track.
No more confusion when changing the way—
Each animation now knows how to sway!
A hop and a twirl, transitions delight,
This rabbit approves: the carousel’s right! 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/lib/carousel/Carousel.svelte

Oops! Something went wrong! :(

ESLint: 9.24.0

Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@eslint/js' imported from /eslint.config.js
at packageResolve (node:internal/modules/esm/resolve:839:9)
at moduleResolve (node:internal/modules/esm/resolve:908:18)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e20d40c and 7942bd1.

📒 Files selected for processing (1)
  • src/lib/carousel/Carousel.svelte (3 hunks)
🔇 Additional comments (4)
src/lib/carousel/Carousel.svelte (4)

21-21: Syntax correction: semicolon added.

The import statement has been properly updated with a semicolon, maintaining consistent syntax throughout the codebase.


64-64: Good implementation of direction tracking.

Explicitly setting _state.forward = true when navigating to the next slide correctly identifies the direction of transition. This enables the carousel to apply the appropriate animation for forward navigation, addressing the issue described in PR #1551.


75-75: Good implementation of direction tracking.

Setting _state.forward = false when navigating to the previous slide correctly identifies the backward transition direction. This complements the change in the nextSlide function and ensures proper animation direction when users navigate backward through the carousel.


7-7: Verified existing state structure supports the implementation.

The implementation leverages the existing forward property in the State type (line 7) and state initialization (line 40). The state subscription (lines 48-52) already updates the local forward variable, ensuring the direction state is properly propagated to components using the carousel state.

Also applies to: 40-50


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@maj0rika maj0rika force-pushed the fix--add-direction-tracking-to-carousel-transitions branch from 07972c3 to 7942bd1 Compare April 16, 2025 06:07
@maj0rika maj0rika changed the title feat: add direction tracking to carousel component fix: add direction tracking to carousel component Apr 16, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carousel has strange transition
1 participant