Fix: update isAuctionExpired function #642

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Open

karacurt wants to merge 2 commits into thirdweb-dev:main from karacurt:fix/english-auction-view-function

karacurt commented May 5, 2024 •

edited

Loading

Issue: This view function is semantically wrong, the auction is expired only if endTimestamp is less than block.timestamp.

Solution: Fixes operator sign to <= instead of >=


          Fix: update isAuctionExpired function

9a4b703

karacurt mentioned this pull request

isAuctionExpired view function is with wrong return value #643

Open


          Fix tests

244d56e

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet