removed files that should not be included and updated .gitignore #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ue55 build version is on the ue55 branch and there are prebuilt 5.5 and 5.4 releases in the releases section |
|
You misunderstood my comment. I'm talking about how built binaries should not be a part of the repo but only releases. You check-in compiled versions directly in the git repo. |
|
Ahh I was conflicted about that one. I wanted people to be able to just
clone the repo as well since that’s what I typically do…. I’m really
thinking I should just retire the repo and do fab releases to stop being so
confusing…. Thoughts?
…On Fri, Mar 21, 2025 at 9:50 AM Benjamin ***@***.***> wrote:
You misunderstood my comment. I'm talking about how built binaries should
not be a part of the repo but only releases. You check-in compiled versions
directly in the git repo.
—
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACHTFBFUTHJY7EPZE7QOIGD2VQKLXAVCNFSM6AAAAABVAI2ES6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBTGQZDMMRTGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
[image: bennystarfighter]*bennystarfighter* left a comment
(threepeatgames/ThreepeatAnimTools#4)
<#4 (comment)>
You misunderstood my comment. I'm talking about how built binaries should
not be a part of the repo but only releases. You check-in compiled versions
directly in the git repo.
—
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACHTFBFUTHJY7EPZE7QOIGD2VQKLXAVCNFSM6AAAAABVAI2ES6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBTGQZDMMRTGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
I think its awesome that this is on GitHub, its a great contribution to the unreal engine open source space so I do not think you should go fab-only. Its easy enough to solve and this PR takes care of removing the files and updating your .gitignore, and your releases with the prebuilt binaries will still be there. |
|
Ok, you talked me into it!
…On Fri, Mar 21, 2025 at 12:49 PM Benjamin ***@***.***> wrote:
I think its awesome that this is on GitHub, its a great contribution to
the unreal engine open source space so I do not think you should go
fab-only. Its easy enough to solve and this PR takes care of removing the
files and updating your .gitignore, and your releases with the prebuilt
binaries will still be there.
—
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACHTFBEQWJWZO4APH4OEZ3L2VQ7KTAVCNFSM6AAAAABVAI2ES6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBTHEZDGNZYG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
[image: bennystarfighter]*bennystarfighter* left a comment
(threepeatgames/ThreepeatAnimTools#4)
<#4 (comment)>
I think its awesome that this is on GitHub, its a great contribution to
the unreal engine open source space so I do not think you should go
fab-only. Its easy enough to solve and this PR takes care of removing the
files and updating your .gitignore, and your releases with the prebuilt
binaries will still be there.
—
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACHTFBEQWJWZO4APH4OEZ3L2VQ7KTAVCNFSM6AAAAABVAI2ES6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBTHEZDGNZYG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build output files should not be tracked in the source repository tree.
This causes issues especially when the plugin is used as a git submodule and changes are recognized just because you've compiled the plugin again.
If its meant as a way to share prebuilt versions for the launcher release of Unreal i can highly recommend tagging and making a github release for the versions instead. Which will let you upload a zip with the packaged version.Saw that you do use releases.