Skip to content

Weatherbard app #3021

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Weatherbard app #3021

wants to merge 4 commits into from

Conversation

mgtkach
Copy link

@mgtkach mgtkach commented Apr 23, 2025

This app takes the weather condition from openweatherapp and returns one or poetic lines that describe that condition. It will randomly choose from many.

@tidbyt
Copy link

tidbyt bot commented Apr 23, 2025

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of cache.star requires review
Original Author The original author matches the PR author

@tidbyt-bot
Copy link

tidbyt-bot commented Apr 23, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@mgtkach
Copy link
Author

mgtkach commented Apr 23, 2025

I have read the CLA Document and I hereby sign the CLA

@danielsitnik
Copy link
Collaborator

@mgtkach this app has an OpenWeatherMap API key stored in plain text inside the file. You should be using Pixlet's Secret Module for this.

Also, I noticed that the http call to OpenWeatherMap is not using the Cache Module. If the app is installed by many users this has the potential to hit the API rate limits.

@mgtkach mgtkach closed this May 3, 2025
@mgtkach mgtkach reopened this May 3, 2025
@mgtkach mgtkach force-pushed the weatherbard-app branch 3 times, most recently from 964b859 to 9c546cb Compare May 3, 2025 20:05
@mgtkach mgtkach force-pushed the weatherbard-app branch from 9c546cb to 7fd4d32 Compare May 3, 2025 20:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants