Skip to content

Commit a73cd32

Browse files
topepo‘topepo’hfrick
authored
changes for #1039 (#1066)
* changes for #1039 * Update NEWS.md Co-authored-by: Hannah Frick <hfrick@users.noreply.github.com> --------- Co-authored-by: ‘topepo’ <‘mxkuhn@gmail.com’> Co-authored-by: Hannah Frick <hfrick@users.noreply.github.com>
1 parent 525baee commit a73cd32

File tree

3 files changed

+2
-2
lines changed

3 files changed

+2
-2
lines changed

NEWS.md

+2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# parsnip (development version)
22

3+
* We no longer add `eval_time` arguments to the prediction specification for the engine (#1039).
4+
35
* parsnip now lets the engines for [mlp()] check for acceptable values of the activation function (#1019)
46

57
* Tightened logic for outcome checking. This resolves issues—some errors and some silent failures—when atomic outcome variables have an attribute (#1060, #1061).

R/predict_hazard.R

-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ predict_hazard.model_fit <- function(object,
3333
new_data <- object$spec$method$pred$hazard$pre(new_data, object)
3434

3535
# Pass some extra arguments to be used in post-processor
36-
object$spec$method$pred$hazard$args$eval_time <- eval_time
3736
pred_call <- make_pred_call(object$spec$method$pred$hazard)
3837

3938
res <- eval_tidy(pred_call)

R/predict_survival.R

-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ predict_survival.model_fit <- function(object,
3535
new_data <- object$spec$method$pred$survival$pre(new_data, object)
3636

3737
# Pass some extra arguments to be used in post-processor
38-
object$spec$method$pred$survival$args$eval_time <- eval_time
3938
pred_call <- make_pred_call(object$spec$method$pred$survival)
4039

4140
res <- eval_tidy(pred_call)

0 commit comments

Comments
 (0)