Skip to content

changes for #1039 #1066

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Feb 14, 2024
Merged

changes for #1039 #1066

merged 2 commits into from
Feb 14, 2024

Conversation

topepo
Copy link
Member

@topepo topepo commented Feb 14, 2024

Closes #1039

Tested on extratests via devtools::test(filter = "(survival)|(censor)")

Copy link
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bye bye special case! 🎉

Co-authored-by: Hannah Frick <hfrick@users.noreply.github.com>
@topepo topepo merged commit a73cd32 into main Feb 14, 2024
@topepo topepo deleted the eval-time-injection branch February 14, 2024 20:15
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 29, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove forced injection of eval_time in predict_survival()
2 participants