Skip to content

Remove Test SDK reference #101

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove Test SDK reference #101

wants to merge 1 commit into from

Conversation

relaxnow
Copy link

@relaxnow relaxnow commented Apr 2, 2024

Project is not a test project.

@relaxnow
Remove Test SDK reference
142657e 
Project is not a test project.
@relaxnow
Copy link
Author

relaxnow commented Apr 4, 2024

Hi @tobyash86 ! Thanks for creating this fork of WebGoat.NET updated to .NET 8!
I was testing this with Veracode Static Analysis and noticed that it's being marked as a test project due to Microsoft.NET.Test.Sdk being referenced. I think this is a bug that happened when migrating to .NET 8.
Could you consider removing that reference if it's not used? Or maybe I'm missing something and there are tests? I did see a PR for adding a test project?

@relaxnow
Copy link
Author

Hi @tobyash86 ! Could you take a look at this?

@relaxnow
Copy link
Author

@tobyash86 ?

2 similar comments
@relaxnow
Copy link
Author

@tobyash86 ?

@relaxnow
Copy link
Author

@tobyash86 ?

@relaxnow
Copy link
Author

@tobyash86 could you take a look at this?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@relaxnow