Pvs studio #1167
Open
Pvs studio #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of these errors was generated by PVS Studio - automatic analysis tool i used to check the code. These are just a small fraction of what was found. The most interested for me. Some may be false-positive though most of them were filtered by me.
Please someone with experience and code knowledge take a look.
If community is interested i can share a full log and anyone with PVS installed can fix them.
There is a lot of performace-related issues such as trying to move const or const ref (&) objects (which results in simple copying), passing large objects by value (such as strings). I have zero interest in PVS, just a TON user who decide to spend couple of hours setting up windows build and checking for mistakes and errors. In hope this will make TON better