feature: introduce monkey patcher to make adapters configurable #153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, I encountered an issue while adding Sentry to our project. After adding a simple Sentry initializer, all of our HTTP requests started failing with a "Stack too deep" exception. It turned out that both the
sentry-ruby
andhttplog
gems patch theNet::HTTP
class, buthttplog
does so in a way that creates a loop with other patches.Sentry::Net::HTTP
- https://github.com/getsentry/sentry-ruby/blob/master/sentry-ruby/lib/sentry/net/http.rbTo resolve this issue, I introduced a lazy monkey patcher that allows users to configure the required patches themselves. This makes the gem more flexible when used alongside other custom patches and resolves the issue mentioned above
Major changes:
.alias
method usage due to its unpredictable behaviourMonkeyPatcher
class which stores adapters and applies them based on the user's configuration#configure
method prepends patching modules, meaning it has to be called at the application start. Maybe it is a good idea to make alias method#init
, for convenience