Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

pass twine publish args in deploy_pip #411

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

mgosk
Copy link

@mgosk mgosk commented Apr 9, 2024

What is the goal of this PR?

Be able to pass twine args eg --skip-existing , "--non-interactive"

What are the changes implemented in this PR?

Pass twine publish args in deploy_pip function

Live tested on private repository together with other waiting PRs https://github.com/mgosk/bazel-distribution/tree/bzlmod-with-pypi

@alexjpwalker
Copy link
Member

alexjpwalker commented Jun 13, 2024

hi @mgosk , thank you for the contribution!

This change would be more explicit and aligned with the other rules in bazel_distribution if the arguments supported by twine were each individually configurable in the rule's arguments.

Something like

        "skip_existing": attr.bool(
            default = False,
            doc = "Continue uploading files if one already exists. (Only valid when uploading to PyPI. Other implementations may not support this.)"
        ),

@alexjpwalker alexjpwalker self-requested a review June 13, 2024 10:16
@alexjpwalker alexjpwalker self-assigned this Jun 13, 2024
Copy link
Member

@alexjpwalker alexjpwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented in main thread

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants