Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Typesense updates #1

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Typesense updates #1

wants to merge 20 commits into from

Conversation

shivag46
Copy link

@shivag46 shivag46 commented Apr 5, 2021

Change Summary

PR Checklist

@jasonbosco
Copy link
Member

@shivag46 At a high level the approach looks good.

However, it looks like there a couple files which have bad merge code. For eg. Could you resolves these merge issues?

Separately, I also see some code that's commented out like this. I'm guessing it's just to test functionality out?

Could you rename includes/libraries/typesensesearch-client-php to includes/libraries/typesense-php since that's the name of the library?

@shivag46
Copy link
Author

shivag46 commented Apr 7, 2021

I have resolved the merge conflicts and renamed the library folder.

And about the commented out sections, few of them were Algolia related code that were unnecessary for our project and the rest are some additional features that I need to work on.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants