-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore(deps): update dependency @changesets/read to ^0.6.2 #200
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 31c8c9f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use yarn instead.
@@ -1649,13 +1656,31 @@ | |||
micromatch "^4.0.2" | |||
spawndamnit "^2.0.0" | |||
|
|||
"@changesets/git@^3.0.2": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems there are some duplicate but incomparable @changesets/
packages, can we upgrade them together?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay thanks @JounQin I saw @changesets/errors
and @changesets/parse
in the package and matched with the lock versions. I'm hoping that covers related dependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trystendsmyth Why other @changesets
deps could not be upgraded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JounQin the intent of this PR is to fix #199 and pass audit. The package upgrades made will achieve that. I would like to propose merging this PR as is.
I am happy to follow up with another PR for full dependency upgrades, but some of those also want Node v22, so may want to be reviewed and tested separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't follow which depends cross-spawn
exactly, the yarn.lock
doesn't show v5 to v7 change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JounQin look here where the lock file is updated to the latest version of cross-spawn
. This is good enough for consuming packages to pass audit.
However if you want this package to pass audit as well, that requires a full dependency update. I can push a commit to do that, but there's a catch. One of the primary audit offenders is type-coverage
. However, anything past 2.27.0
requires a later version of Node. Do you want to move your package to Node 20.x or 22.x? If so, I can do a full upgrade and change the engine node requirement. Do you want to do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine to align node versions support with upstream.
@changesets/errors to ^0.2.0 and @changesets/parse to ^0.4.0
This updates a dependency to pass auditing.
Fix #199