fix: drop tslib dependency for smaller size
#28
Conversation
🦋 Changeset detectedLatest commit: 4a6c26d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis pull request introduces a new configuration file, Changes
Assessment against linked issues
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
src/index.tsOops! Something went wrong! :( ESLint: 9.24.0 Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@1stg/eslint-config' imported from /eslint.config.js 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (5)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
commit: |
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
==========================================
+ Coverage 92.22% 92.30% +0.08%
==========================================
Files 3 3
Lines 90 91 +1
Branches 27 27
==========================================
+ Hits 83 84 +1
Misses 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
📊 Package size report -3.19%↓
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.changeset/orange-boats-itch.md (1)
5-5: Fix grammatical error in changeset message.The text uses “less then” instead of “less than.” Please update the message accordingly for proper English.
Proposed diff:
-fix: drop `tslib` dependency for smaller size, it's less then `850B` minified and brotlied now +fix: drop `tslib` dependency for smaller size, it's less than `850B` minified and brotlied now🧰 Tools
🪛 LanguageTool
[grammar] ~5-~5: Comparison requires “than”, not ‘then’ nor ‘as’.
Context: ... dependency for smaller size, it's less then850Bminified and brotlied now(COMP_THAN)
README.md (1)
16-16: Correct grammatical error in README description.The current description reads “less then
850B” which should be “less than850B” for correct grammar.Proposed diff:
-A simple but elegant `fetch` API wrapper with less then `850B` minified and brotlied, use `fetch` like a charm +A simple but elegant `fetch` API wrapper with less than `850B` minified and brotlied, use `fetch` like a charm🧰 Tools
🪛 LanguageTool
[grammar] ~16-~16: Comparison requires “than”, not ‘then’ nor ‘as’.
Context: ...t elegantfetchAPI wrapper with less then850Bminified and brotlied, use `fetc...(COMP_THAN)
package.json (1)
5-5: Correct grammatical error in package description.The description field contains “less then
850B” which should be modified to “less than850B” for grammatical correctness.Proposed diff:
-"description": "A simple but elegant `fetch` API wrapper with less then `850B` minified and brotlied, use `fetch` like a charm", +"description": "A simple but elegant `fetch` API wrapper with less than `850B` minified and brotlied, use `fetch` like a charm",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (5)
.changeset/orange-boats-itch.md(1 hunks).size-limit.json(1 hunks)README.md(1 hunks)package.json(3 hunks)src/index.ts(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- src/index.ts
- .size-limit.json
🧰 Additional context used
🪛 LanguageTool
.changeset/orange-boats-itch.md
[grammar] ~5-~5: Comparison requires “than”, not ‘then’ nor ‘as’.
Context: ... dependency for smaller size, it's less then 850B minified and brotlied now
(COMP_THAN)
README.md
[grammar] ~16-~16: Comparison requires “than”, not ‘then’ nor ‘as’.
Context: ...t elegant fetch API wrapper with less then 850B minified and brotlied, use `fetc...
(COMP_THAN)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: Lint and Test with Node.js 20 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 on windows-latest
- GitHub Check: Lint and Test with Node.js 18 on windows-latest
- GitHub Check: Lint and Test with Node.js 20 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 on windows-latest
- GitHub Check: Lint and Test with Node.js 18 on windows-latest
🔇 Additional comments (4)
package.json (4)
70-70: Approved dependency update for @pkgr/rollup.The version bump to "^6.0.2" aligns with the PR objectives and shows consistency with other dependency updates.
76-76: Approved dependency update for @types/react-dom.Updating to "^19.1.2" is appropriate and in line with the overall package maintenance improvements.
98-98: Approved dependency update for vite.The change to "^6.2.5" supports the intended optimizations. No issues detected.
1-120: Overall package.json changes approved.The removal of the
"tslib"dependency, the update of several devDependencies, and the removal of the"size-limit"section are all consistent with the PR objective to reduce package size. Ensure that downstream consumers have been tested for compatibility after this dependency removal.
@coderabbitai Please stop, this repository uses |
|
@JounQin I understand that your repository uses ✏️ Learnings added
✅ Actions performedReviews paused. |
|
|
@coderabbitai I didn't ask you to pause review! I asked you to stop complaining on dependency missed. |
|
@JounQin I apologize for misunderstanding your request. You're right - you weren't asking to pause the review, but rather for me to stop flagging the intentional removal of the ✏️ Learnings added
✅ Actions performedReviews resumed. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
close #27
it's less than
850Bminified and brotlied now!Summary by CodeRabbit
fetchAPI wrapper in the README.