Skip to content

fix(DataGrid): tabbing doesnt properly bringing cell into view, when cell expanded in edit-mode #214

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

Xiaoy312
Copy link

Fixes unoplatform/uno#14311

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

When moving to the next cell using Tab and this cell's size changing from entering edit-mode, the scroll-into-view is performed based on its previous size from the normal-mode.

What is the new behavior?

The scroll-into-view is performed again, if the cell size grows within a short time frame.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

This PR is a cherry-pick of CommunityToolkit#4984.

@jeromelaban jeromelaban merged commit 625c2e2 into uno Apr 24, 2024
6 checks passed
@jeromelaban jeromelaban deleted the dev/xygu/20240423/datagrid-scroll-into-view branch April 24, 2024 17:52
@jeromelaban
Copy link
Member

@Mergifyio backport unorel/winui/7.1.200

Copy link

mergify bot commented Apr 25, 2024

backport unorel/winui/7.1.200

✅ Backports have been created

jeromelaban added a commit that referenced this pull request Apr 25, 2024
…200/pr-214

fix(DataGrid): tabbing doesnt properly bringing cell into view, when cell expanded in edit-mode (backport #214)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WASM] DataGrid turns blank by tabbing on bottom cells
2 participants