-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add a compose export #3
base: master
Are you sure you want to change the base?
Conversation
Don't pull yet. I've noticed some artifacts from this What do you think about the API? It's not a true |
Hey, I'm going to get back to this later tonight and add support for more arguments, I think 12 should be enough and change the implementation so that it does not need to be called, explained below. I realized that you don't really want to supply the final argument to the import { composeBuilders } from 'njsx'
const Root = ({ store }) =>
composeBuilders(
Provider({ store }),
PersistGate({ loading: null, persistor }),
Router({ history }),
Route({ path: '/', component: App })
)(null)() However, I think it would be better to not even have to call it with I'm thinking import { nest } from 'njsx'
const Root = ({ store }) =>
nest(
Provider({ store }),
PersistGate({ loading: null, persistor }),
Router({ history }),
Route({ path: '/', component: App })
)() |
I've noticed that implementations of compose vary greatly and especially the libraries that support placeholders seem to fail on Builders.
I thought it would be better if
njsx
supplied it's own compose function so I added.Let me know if you can try it out and if you have any issue with it.