Fix typos #74
Merged
Fix typos #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are all of these changes in comments, or is any active code involved? |
|
There are a few visible error messages, axis titles, but seems like 99% of this PR are corrections in comments, mostly the database. As mentioned above, there is a split of spelling between lamda vs lambda, which is active code. These changes are not done in this PR as it would be better to discuss further these implications. |
|
I will talk to Scott Charlton. We once changed the formatting of all of the
code, and it made it really difficult to track changes after that, so I
will have to look more carefully at the implications.
The "lamda" came from copying too closely the phrqpitz code without
realizing the misspelling. Some retention would be necessary to maintain
backward compatibility.
I am busy for a couple of weeks, but Scott and I will discuss it when I get
back. No promises, but thanks for your interest.
David
…On Tue, Sep 24, 2024 at 6:27 PM Mike Taves ***@***.***> wrote:
There are a few visible error messages, axis titles, but seems like 99% of
this PR are corrections in comments, mostly the database.
As mentioned above, there is a split of spelling between lamda vs lambda,
which is active code. These changes are not done in this PR as it would be
better to discuss further these implications.
—
Reply to this email directly, view it on GitHub
<#74 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APZJL55J2G6ITH424A4IXELZYH7QXAVCNFSM6AAAAABOFDWPWGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZSGYZDIOBTHE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
scharlton2
pushed a commit
that referenced
this pull request
Oct 8, 2024
9e8d773e Merge pull request #74 from mwtoews/fix-typos dc8e003f Fix typos git-subtree-dir: database git-subtree-split: 9e8d773e18b9bbd8517b340061d6f509515fa019
scharlton2
pushed a commit
that referenced
this pull request
Oct 8, 2024
c876219b Merge commit '64310ada821d1cc387af4507db7029fe3326784b' 64310ada Squashed 'common/' changes from 399aba2..648db22 7c7fafd6 Merge pull request #78 from dlparkhurst/mix_error eb0591c9 Merge pull request #74 from mwtoews/fix-typos 334df5ea Tony's fix in heat transport bf897a2b Marked old error in mix. Updated test case. 58566a60 Fix ah2o in adding a solution. Fixed bad_graph database. 75effd02 Merge branch 'viscosity' into mix_error f4708df2 account for water mass in addition to mixing fractions 70954c61 mixing by water mass times mixing fraction 84b59ab7 Fix typos git-subtree-dir: src git-subtree-split: c876219b1b064ab7c17e0bc4ad8bff13e0aeb108
scharlton2
pushed a commit
that referenced
this pull request
Oct 8, 2024
757561b9 Merge pull request #74 from mwtoews/fix-typos bf3dc34a Fix typos git-subtree-dir: examples git-subtree-split: 757561b99b22211b09448495a06c2478e5cb9ef1
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few typos, found with codespell.
Note that I've left ~135 instances of the common misspelling "lamda" alone for now, but there are also ~154 instances of the correctly spelled "lambda". Should these be changed?