Mix error #82
Merged
Mix error #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like more than TRANSPORT is failing: https://my.cdash.org/viewTest.php?onlyfailed&buildid=2692924 Let me know if you're okay with these diffs. |
|
I think it is probably okay because changes in viscosity affect specific
conductance, but let me check through carefully. Hopefully, I can get to it
tomorrow.
…On Thu, Oct 17, 2024 at 11:18 AM Charlton, Scott R. < ***@***.***> wrote:
Looks like more than TRANSPORT is failing:
https://my.cdash.org/viewTest.php?onlyfailed&buildid=2692924
Let me know if you're okay with these diffs.
—
Reply to this email directly, view it on GitHub
<#82 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APZJL53DEXWKIXYGYSB3IZTZ37WO5AVCNFSM6AAAAABQCYPMN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRQGA4DQMZSHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I went through the diffs carefully, and I think it is okay to check them
in. Most diffs were in the 1e-3 range, with the large ones (0.1) related to
multicomponent diffusion.
On Thu, Oct 17, 2024 at 1:40 PM David Parkhurst ***@***.***>
wrote:
… I think it is probably okay because changes in viscosity affect specific
conductance, but let me check through carefully. Hopefully, I can get to it
tomorrow.
On Thu, Oct 17, 2024 at 11:18 AM Charlton, Scott R. <
***@***.***> wrote:
> Looks like more than TRANSPORT is failing:
>
> https://my.cdash.org/viewTest.php?onlyfailed&buildid=2692924
>
> Let me know if you're okay with these diffs.
>
> —
> Reply to this email directly, view it on GitHub
> <#82 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/APZJL53DEXWKIXYGYSB3IZTZ37WO5AVCNFSM6AAAAABQCYPMN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRQGA4DQMZSHA>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed problems with mixing and the new variables Tony added. Updated RELEASE.TXT. All the test cases run, but there will be diffs related to TRANSPORT.
I think we are ready for 8.3.3 when you have the time, but make sure it is run through Valgrind and all the other tests first.