Skip to content

fix: parse boolean and int attributes value #69

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amihalj
Copy link

@amihalj amihalj commented Sep 15, 2023

Considering example:

<div
  class="lazyframe"
  data-vendor=""
  data-title=""
  data-thumbnail=""
  data-src=""
  data-ratio="1:1"
  data-initinview="false"
  data-autoplay="false"
></div>

Even-though data-autoplay="false" autoplay will be considered as true due to string value. This results in all attributes being evaluated as strings.

explicitly examing ['autoplay','initinview'] as boolean and ['debounce'] as integer will values passed as attributes correspond to preferred types

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant