Skip to content

Expand y_range Search for ymax #2959

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
amin1377 opened this issue Apr 1, 2025 · 1 comment
Open

Expand y_range Search for ymax #2959

amin1377 opened this issue Apr 1, 2025 · 1 comment
Assignees

Comments

@amin1377
Copy link
Contributor

amin1377 commented Apr 1, 2025

In the find_compatible_compressed_loc_in_range function (Link), after an x location is chosen (in the compressed grid), the function retrieves the y locations of the corresponding x location (where blocks of the given type exist in that column) and checks if search_range.ymin exists in the column. If it doesn't, the search range is expanded to include the entire column (Link). I was wondering if expanding the search range to the entire column when ymax doesn't exist has been tried. The current implementation effectively moves IO blocks from the top edge to the bottom edge, but not vice versa.
@vaughnbetz: I can implement it if you think it is worth trying, and let you know the results.

@amin1377 amin1377 self-assigned this Apr 1, 2025
@vaughnbetz
Copy link
Contributor

That sounds reasonable to me. Not being able to move I/Os from the top to the bottom edge will not be good -- easy to get stuck. Seems worth trying.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants