-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: support template props omitted #265
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for vapor-template-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for vapor-repl ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size ReportBundles
Usages
|
commit:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding this PR, here are some of my thoughts:
- If props are not needed, maybe you can skip generating them.
- Follow the existing definition and change
_props
to$props
.
Also, I tried it in the Playground, and it doesn't seem to work properly.
oh,Looks like I'm missing a part of the code |
2bf3c5e
to
8ea6e4f
Compare
playground