Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

docs(tf-414): different markups for components #7413

Merged
merged 13 commits into from
Mar 25, 2025
Merged

docs(tf-414): different markups for components #7413

merged 13 commits into from
Mar 25, 2025
+675 −1

Conversation

dawid-ziobro
Copy link
Contributor

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: bed7d47

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dawid-ziobro dawid-ziobro requested a review from mateuszo March 17, 2025 09:23
@dawid-ziobro dawid-ziobro requested a review from jagoral March 18, 2025 10:39
jagoral
jagoral approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@jagoral jagoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

mateuszo
mateuszo requested changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@mateuszo mateuszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% satisfied with the guide. It's vague in some places - mentions problems but not exact solutions and does not mention consequences.

@dawid-ziobro dawid-ziobro requested a review from mateuszo March 20, 2025 15:25
mateuszo
mateuszo requested changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@mateuszo mateuszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a lot better now. However it got me thinking more deeply about it and trying it out and I found out that adding required props in overrides should be forbidden because it breaks the Liskov Substitution Principle - read one of the comments for more details.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dawid-ziobro dawid-ziobro merged commit 2b68c96 into docs/multibrand2 Mar 25, 2025
3 checks passed
@dawid-ziobro dawid-ziobro deleted the docs/tf-414-different-markups-for-components branch March 25, 2025 10:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mateuszo mateuszo mateuszo approved these changes

@jagoral jagoral jagoral approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dawid-ziobro @mateuszo @jagoral