Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Important JS topics #8

Merged
merged 7 commits into from
Oct 17, 2020
Merged

Important JS topics #8

merged 7 commits into from
Oct 17, 2020

Conversation

yashi12
Copy link
Contributor

@yashi12 yashi12 commented Oct 15, 2020

I have added important topics to be learnt in JS (advanced topics) usually which students do not consider. Issue( #1)

@yashi12 yashi12 mentioned this pull request Oct 15, 2020
Open
@vyasriday
Copy link
Owner

This is just a list of topics and it's pdf. I am sorry but I can't merge it.

@yashi12
Copy link
Contributor Author

yashi12 commented Oct 15, 2020

This is just a list of topics and it's pdf. I am sorry but I can't merge it.

I converted list to PDF so that it becomes easy for user to understand.
Can u plz suggest what else do u want in it so that I can add those things to it?

@vyasriday
Copy link
Owner

This repo contains some info about the topic mentioned. Yours is just a list of topics which can be useful. You can list those topics here but it would be great if you could write something about the topic you know.

@yashi12
Copy link
Contributor Author

yashi12 commented Oct 15, 2020

This repo contains some info about the topic mentioned. Yours is just a list of topics which can be useful. You can list those topics here but it would be great if you could write something about the topic you

Sure I will write about some of the topics.

@yashi12
Copy link
Contributor Author

yashi12 commented Oct 16, 2020

This repo contains some info about the topic mentioned. Yours is just a list of topics which can be useful. You can list those topics here but it would be great if you could write something about the topic you know.

Plz have a look at the PR, I have made the changes to it, and plz merge it:
Changed from Pdf to markdown
Added content about the topics -->(Keywords,Promises,Async-Await, Requests)
Added Code snippets to describe them

@yashi12
Copy link
Contributor Author

yashi12 commented Oct 17, 2020

@vyasriday plz view my PR

@vyasriday vyasriday merged commit e19c53c into vyasriday:master Oct 17, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vyasriday vyasriday vyasriday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yashi12 @vyasriday