Responsive sponsor ad #7228
Open
Responsive sponsor ad #7228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JamesSwinton is attempting to deploy a commit to the Webpack Docs Team on Vercel. A member of the Team first needs to authorize it. |
|
@JamesSwinton Can you add screenshots before/after, thank you |
|
Hey @alexander-akait, sure, no problem: Before: After: |
alexander-akait
previously approved these changes
Apr 11, 2024
|
Can you rebase? |
|
Should be ready to merge now, thanks |
|
Not sure we want to show ads on top of small screens, it would be terrible UX IMO. |
|
I agree, showing add on top would shift the content below leading to a degraded UX. Maybe we can do something similar to ESLint, it moves the ad to the footer on small screens. 
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated the AG Grid sponsor section so that it appears on small & mobile devices.