Skip to content

fix: Hide incorrect menu item for running workflow crawl #2591

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
May 6, 2025
Merged

fix: Hide incorrect menu item for running workflow crawl #2591

merged 2 commits into from
May 6, 2025

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented May 6, 2025

Resolves #2589

Changes

  • Hides the "Delete" menu item for a running crawl in the workflows crawls list.
  • Slightly grays out row for running crawl to indicate that it's not clickable.

Manual testing

  1. Log in as crawler
  2. Start a crawl
  3. Go to workflow -> Crawls
  4. Click "..." menu icon in running crawl row. Verify "Delete" is not visible

Screenshots

Page Image/video
Workflow - Crawls Screenshot 2025-05-05 at 5 13 56 PM

@SuaYoo SuaYoo requested review from ikreymer, emma-sg and tw4l May 6, 2025 00:18
@SuaYoo SuaYoo force-pushed the frontend-fix-workflow-crawl-action-menu branch from 82bef1e to 2cc477c Compare May 6, 2025 21:33
@SuaYoo SuaYoo merged commit cb6e279 into main May 6, 2025
27 checks passed
@SuaYoo SuaYoo deleted the frontend-fix-workflow-crawl-action-menu branch May 6, 2025 22:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@emma-sg emma-sg emma-sg approved these changes

@tw4l tw4l tw4l approved these changes

@ikreymer ikreymer Awaiting requested review from ikreymer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: "Delete" action menu option shown for running crawl
3 participants
@SuaYoo @emma-sg @tw4l