Retarget for .net 7 #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retain net6.0 for those on LTS release Remove .net 5 and netcoreapp 3.1 Change net461 to net462 and drop netstandard2.1
|
Thanks for the PR. I will take a look when I got time. |
weichch
reviewed
Jun 25, 2023
There was a problem hiding this comment.
We also need to bump up the version of the packages to 2.0.0 given it is a major update.
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="System.Text.Json" Version="6.0.0" /> | ||
| <PackageReference Include="System.Text.Json" Version="7.0.3" /> |
There was a problem hiding this comment.
I'm not sure if we should go to the latest version. I reckon the base version 7.0.0 would be enough for most users and leave it to them to use patched versions? Thoughts?
| @@ -1,7 +1,7 @@ | |||
| <Project> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFrameworks>netstandard2.0;netstandard2.1;net461</TargetFrameworks> | |||
| <TargetFrameworks>netstandard2.0;net462</TargetFrameworks> | |||
There was a problem hiding this comment.
I'm thinking we should probably add net7.0 and net6.0 to the list to match the latest targeting frameworks of System.Text.Json.
|
I'm closing this due to lack of response. This issue has been completed in #43 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retain net6.0 for those on LTS release
Remove .net 5 and netcoreapp 3.1
Change net461 to net462 and drop netstandard2.1
Also upgrades third party dependencies - inc. Test frameworks
Addresses: #32