make wolfSSL_UseALPN take const char* rather than char*
#8002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Does wolfssl currently have an api to clear the set alpn? If no, the |
|
Hi @ycdev1 Thanks for this suggestion. Could you tell us a bit about your project using wolfSSL? We do not typically accept small changes to the library. Do you think you will propose more changes in the future? Thanks, |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
wolfSSL_UseALPNtakeschar*argument which suggests that it mutates the data it receives while it just copies the data to a temporary allocated buffer so it should takeconst char*instead.Also
wolfSSL_ALPN_GetProtocolshould outputconst char*but this may break existing code.