Skip to content

DTLS: drop records that span datagrams #8642

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
May 23, 2025

Conversation

rizlik
Copy link
Contributor

@rizlik rizlik commented Apr 7, 2025

Description

DTLS records should not span UDP datagrams, this PR adds an API to enforce it.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • doc/dox_comments/header_files/ssl.h: Language not supported

@rizlik rizlik force-pushed the dtls_no_span_records branch 4 times, most recently from c818750 to b8c12fb Compare April 7, 2025 13:57
@rizlik
Copy link
Contributor Author

rizlik commented Apr 8, 2025

retest this

@julek-wolfssl julek-wolfssl removed their assignment Apr 9, 2025
@gojimmypi
Copy link
Contributor

Jenkins retest this please

for long-running job

@rizlik rizlik force-pushed the dtls_no_span_records branch 3 times, most recently from 7147388 to 72a3693 Compare April 22, 2025 15:55
@rizlik
Copy link
Contributor Author

rizlik commented Apr 22, 2025

retest this please

@rizlik rizlik force-pushed the dtls_no_span_records branch 4 times, most recently from c9b5fb0 to a81e244 Compare April 29, 2025 09:58
@rizlik
Copy link
Contributor Author

rizlik commented Apr 29, 2025

retest this please

@rizlik rizlik force-pushed the dtls_no_span_records branch 2 times, most recently from 2095c71 to 1bb45f5 Compare May 7, 2025 10:34
@kaleb-himes
Copy link
Contributor

retest this please

@rizlik
Copy link
Contributor Author

rizlik commented May 8, 2025

retest this please

@rizlik rizlik assigned julek-wolfssl and unassigned rizlik May 8, 2025
Copy link
Member

@julek-wolfssl julek-wolfssl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment unresolved and rebase and fix conflict.

@rizlik rizlik force-pushed the dtls_no_span_records branch 4 times, most recently from 8bd7211 to bb0f5bc Compare May 14, 2025 14:03
@rizlik
Copy link
Contributor Author

rizlik commented May 14, 2025

retest this please

@rizlik rizlik changed the title DTLS: add api to enforce records do not span datagrams DTLS: drop records that span datagrams May 14, 2025
@rizlik rizlik requested a review from julek-wolfssl May 15, 2025 07:39
@rizlik rizlik assigned julek-wolfssl and unassigned rizlik May 15, 2025
julek-wolfssl
julek-wolfssl previously approved these changes May 16, 2025
@douzzer douzzer assigned rizlik and douzzer and unassigned wolfSSL-Bot May 16, 2025
rizlik added 3 commits May 19, 2025 10:25
To uniform error handling for the SanityCheckCipherText check.
A new macro "WOLFSSL_DTLS_RECORDS_CAN_SPAN_DATAGRAMS" restores the old
behaviour.
@rizlik
Copy link
Contributor Author

rizlik commented May 19, 2025

retest this please

@rizlik rizlik removed their assignment May 19, 2025
@rizlik rizlik requested a review from douzzer May 21, 2025 07:56
@SparkiDev SparkiDev merged commit 999641d into wolfSSL:master May 23, 2025
204 checks passed
@SparkiDev SparkiDev assigned SparkiDev and unassigned douzzer May 23, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants