Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Order editing] Disabled product selection looks like enabled #13782

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from

Conversation

kidinov
Copy link
Contributor

@kidinov kidinov commented Mar 17, 2025

Closes: #13781

Description

The PR make it visible that selection of products is disabled on the completed orders

Steps to reproduce

  • Open completed orders on a tablet
  • Notice that selection of the products looks like it's enabled

Testing information

  • Use tablet
  • Open both completed and not completed order
  • Notice that in completed selection of the products disabled and it's visible

The tests that have been performed

Above

Images/gif

03-17--16-00.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

kidinov added 3 commits March 17, 2025 15:53

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@kidinov kidinov added the feature: order editing Related to unified order editing. label Mar 17, 2025
@kidinov kidinov added this to the 22.0 milestone Mar 17, 2025
@kidinov kidinov requested a review from samiuelson March 17, 2025 15:18

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Mar 17, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commita4ce870
Direct Downloadwoocommerce-wear-prototype-build-pr13782-a4ce870.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Mar 17, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commita4ce870
Direct Downloadwoocommerce-prototype-build-pr13782-a4ce870.apk

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.

Project coverage is 38.03%. Comparing base (0a5d461) to head (a4ce870).

Files with missing lines Patch % Lines
...i/products/selector/components/SelectorListItem.kt 0.00% 44 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #13782      +/-   ##
============================================
- Coverage     38.04%   38.03%   -0.01%     
  Complexity     9221     9221              
============================================
  Files          2074     2074              
  Lines        114434   114463      +29     
  Branches      14564    14571       +7     
============================================
  Hits          43535    43535              
- Misses        66949    66978      +29     
  Partials       3950     3950              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kidinov kidinov requested review from AnirudhBhat and removed request for samiuelson March 20, 2025 07:48
@wpmobilebot wpmobilebot modified the milestones: 22.0, 22.1 Mar 21, 2025
@wpmobilebot
Copy link
Collaborator

Version 22.0 has now entered code-freeze, so the milestone of this PR has been updated to 22.1.

…-search-results-when-editing-a-completed-order-but-it-looks-like-you-can
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature: order editing Related to unified order editing.
Projects
None yet
3 participants