Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update Bank Debit and Alipay Icons #4099

Merged
merged 5 commits into from
Mar 20, 2025

Conversation

rafaelzaleski
Copy link
Contributor

@rafaelzaleski rafaelzaleski commented Mar 19, 2025

Changes proposed in this Pull Request:

This PR updates the Alipay and Bank Debit icons to align with the WooCommerce Design Library. The updated icons appear in both the plugin settings and the checkout pages (Blocks and Shortcode).

Testing instructions

  1. Navigate to the plugin settings page and verify that the updated Alipay and Bank Debit icons are displayed.

Screen Shot 2025-03-19 at 12 09 16 PM

  1. Go to the checkout page (both Blocks and Shortcode) and confirm that the new icons appear correctly.

Blocks

Screen Shot 2025-03-19 at 12 08 42 PM

Shortcode

Screen Shot 2025-03-19 at 12 04 17 PM


  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Comment

Comment

Post merge

@rafaelzaleski rafaelzaleski self-assigned this Mar 19, 2025
@rafaelzaleski
Copy link
Contributor Author

@orcungogus, I added you as a reviewer just to confirm that the screenshots look correct. Thank you!

Copy link
Contributor

@asumaran asumaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orcungogus
Copy link

They look great, thank you very much, @rafaelzaleski!

Copy link

@orcungogus orcungogus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New icons for Alipay and bank transfer look good.

@rafaelzaleski rafaelzaleski enabled auto-merge (squash) March 20, 2025 14:22
@rafaelzaleski rafaelzaleski merged commit ddfac13 into develop Mar 20, 2025
38 checks passed
@rafaelzaleski rafaelzaleski deleted the feat/update-bank-debit-payment-icon branch March 20, 2025 14:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants