Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implementing the order wrapper class in admin classes #4108

Merged
merged 4 commits into from
Mar 21, 2025

Conversation

wjrosa
Copy link
Contributor

@wjrosa wjrosa commented Mar 20, 2025

First PR: #4080

Changes proposed in this Pull Request:

This PR is another in a series of implementations of the proposal of #3654. This iteration implements the order wrapper class on our admin classes.

Testing instructions

Code review. Check if the tests are still passing. A slight smoke test on wp-admin pages would be nice: setting up Stripe, enabling/disabling methods, customizing, editing customers, etc.


  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Comment

Comment

Post merge

@wjrosa wjrosa self-assigned this Mar 21, 2025
@wjrosa wjrosa marked this pull request as ready for review March 21, 2025 12:09
@wjrosa wjrosa requested review from a team and malithsen and removed request for a team March 21, 2025 12:12
Copy link
Contributor

@malithsen malithsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wjrosa wjrosa enabled auto-merge (squash) March 21, 2025 18:56
@wjrosa wjrosa merged commit 3eda8c6 into develop Mar 21, 2025
37 of 38 checks passed
@wjrosa wjrosa deleted the dev/implemeing-order-wrapper-class-in-admin-classes branch March 21, 2025 19:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants