-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Visual changes to SPE in the classic checkout #4119
Visual changes to SPE in the classic checkout #4119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review, Malith! I really appreciate it. I will remove the radio buttons in #4115, so I think it is not worth styling them anymore (that's why I used this PR to also remove some of the styles I applied before). |
Fixes #3896
Changes proposed in this Pull Request:
We are updating the Single Payment Element implementation to make all the payment methods it renders to look just like any other WooCommerce payment method to avoid any UX impact for shoppers. However, the Stripe container has some styling limitations.
This PR applies the required styles for the classic/shortcode checkout.
Preview for multiple payment methods:

Preview when Stripe is the only available method:

This PR also disables the saving of methods and the display of instructions when SPE is enabled on the classic checkout, both will be handled by #4049 and #4048 respectively.
Testing instructions
tweak/visual-changes-to-spe-in-classic-checkout
)https://dashboard.stripe.com/settings/payment_methods
(labeled "Your configuration")client/classic/upe/payment-processing.js:136
npm run build:webpack
)_wcstripe_feature_spe
). You can do it by either hardcoding the return value ofis_spe_available
totrue
or by runningnpm run wp option update _wcstripe_feature_spe 'yes'
wp-admin/admin.php?page=wc-settings&tab=checkout§ion=stripe&panel=settings
)Changelog entry
Changelog Entry Comment
Comment
Post merge