Implement 3D secure check for Google Pay (4156) #3163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the layout of the GooglePay sheet to unlock more test-cards in sandbox mode. It’s the first step in enabling 3DS testing
While removing the PAYMENT_AUTHORIZATION intent, we also removed the processPayment call from the Google Pay button handler. This change restores the correct payment processing flow
This makes the flow easier to understand and debug
This change finally triggers a `PAYER_ACTION_REQUIRED` status response during checkout.
With 3DS the final approval should only fire when the 3DS process was successful. Note that we still need to implement a check to confirm the verification via API
Allows developers to decide if they want an `Order` class for internal usage, or an untyped `stdClass` for ajax responses.
We use the new `::raw_order()` method to return the plain object. The `Order` object could not be serialized in a meaningful way.
Those changes are not relevant for 3DS integration
We don’t need this endpoint, as orders are processed on server side
Make code more readable and maintainable
Dinamiko
approved these changes
Mar 18, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjust the Google Pay logic to accept more test cards by removing the "PAYMENT_AUTHORIZATION" intent
Screenshots
The new Google Pay sheet with additional test cards:
