Skip to content

libworkbench: implement GLogWriterFunc and library initialization #374

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andyholmes
Copy link
Contributor

@andyholmes andyholmes commented Jun 29, 2023

Add Workbench.init() to initialize resources and other setup tasks.

Currently, this only implements a GLogWriterFunc for silencing
specific messages that Workbench users shouldn't see.

This method has some limitations running on other threads in GJS,
and should be more performant in C anyways.

@andyholmes andyholmes requested a review from sonnyp June 29, 2023 23:41
@sonnyp sonnyp self-assigned this Jul 2, 2023
Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the rational / benefit of this in the PR description?

@andyholmes andyholmes force-pushed the andyholmes/libworkbench branch 4 times, most recently from 34287c9 to 71c18cb Compare August 20, 2023 22:05
@andyholmes andyholmes marked this pull request as draft August 20, 2023 22:11
Add `Workbench.init()` to initialize resources and other setup tasks.

Currently, this only implements a `GLogWriterFunc` for silencing
specific messages that Workbench users shouldn't see.

This method has some limitations running on other threads in GJS,
and should be more performant in C anyways.
@andyholmes andyholmes force-pushed the andyholmes/libworkbench branch from 71c18cb to eae9ff0 Compare August 20, 2023 22:16
@andyholmes andyholmes marked this pull request as ready for review August 20, 2023 22:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants