PHPStan level 6 #536
Open
PHPStan level 6 #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
force-pushed
the
add/phpstan
branch
2 times, most recently
from
8f14b59 to
7a36e2a
Compare
swissspidy
commented
May 18, 2025
| */ | ||
| protected function _url( $args, $callback ) { | ||
| foreach ( $args as $obj_id ) { | ||
| $object = $this->fetcher->get_check( $obj_id ); |
There was a problem hiding this comment.
The fetcher property didn't even exist on this abstract class, and in the extending classes it was private. So this code never worked. Plus it was never used, so it's safe to remove.
swissspidy
commented
May 18, 2025
| @@ -182,10 +182,6 @@ public function create( $args, $assoc_args ) { | |||
| $assoc_args['post_category'] = $this->get_category_ids( $assoc_args['post_category'] ); | |||
| } | |||
|
|
|||
| if ( isset( $assoc_args['meta_input'] ) && Utils\wp_version_compare( '4.4', '<' ) ) { | |||
There was a problem hiding this comment.
Figured with our move to WP 4.9+ we can remove this compat code.
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
swissspidy
commented
May 18, 2025
Comment on lines
+325
to
+326
| ? $a->$orderby <=> $b->$orderby | ||
| : $b->$orderby <=> $a->$orderby; |
There was a problem hiding this comment.
I hope this is not the wrong way around 🤔
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.